Add conditional handling for fchdir and chdir functions#14
Open
kateinoigakukun wants to merge 1 commit intovoid-linux:masterfrom
Open
Add conditional handling for fchdir and chdir functions#14kateinoigakukun wants to merge 1 commit intovoid-linux:masterfrom
kateinoigakukun wants to merge 1 commit intovoid-linux:masterfrom
Conversation
Define preprocessor conditions for `HAVE_FCHDIR` to handle platforms without fchdir. On these platforms, pretend that `FTS_NOCHDIR` is always set. This change is necessary to build the `fts` module on the top of the WASI and wasi-libc, which doesn't provide the `fchdir`.
sunfishcode
pushed a commit
to WebAssembly/wasi-libc
that referenced
this pull request
Sep 25, 2024
Close #520 Add FTS implementation derived from musl-fts with a few modifications. The compiled fts.o is included in the libc.a archive, and the fts.h header is installed in the sysroot (`include/fts.h`). * fts/musl-fts: Add a copy of the musl-fts sources with modifications. * fts/patches: A set of patches to apply to the musl-fts sources. * Upstream pull request: void-linux/musl-fts#14 * fts/update-musl-fts.sh: A script to update the musl-fts sources with the patches applied. * fts/config.h: A configuration header included by the musl-fts sources. * test/smoke: Add a test suite for wasi-libc specific features that libc-test does not cover.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define preprocessor conditions for
HAVE_FCHDIRto handle platforms without fchdir. On these platforms, pretend thatFTS_NOCHDIRis always set.This change is necessary to build the
ftsmodule on the top of the WASI and wasi-libc, which doesn't provide thefchdir.